-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3: Optimize IsFromLocal() performance #3140
Conversation
WalkthroughThe changes in this pull request involve the removal of the Changes
Possibly related PRs
Suggested reviewers
Poem
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (3)
Files not reviewed due to no reviewable changes (1)
Additional comments not posted (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3140 +/- ##
==========================================
- Coverage 80.19% 80.11% -0.08%
==========================================
Files 117 117
Lines 9048 9043 -5
==========================================
- Hits 7256 7245 -11
- Misses 1360 1364 +4
- Partials 432 434 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50
.
Benchmark suite | Current: 7b13bfe | Previous: fbc24e8 | Ratio |
---|---|---|---|
BenchmarkAppendMsgitem - MB/s |
3209.82 MB/s |
1847.42 MB/s |
1.74 |
BenchmarkAppendMsgitem - MB/s |
2878.85 MB/s |
1847.42 MB/s |
1.56 |
This comment was automatically generated by workflow using github-action-benchmark.
This is related to this benchmark-action/github-action-benchmark#264 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
ctx.IsFromLocal()
ctx.IsFromLocal()
by usingnet.IP
functions to detect if IP is from loopback address.net.IP
directly instead of strings.Benchmark Results:
Changes introduced
Type of change